On Sat, 12 Jul 2025 at 07:28, Eric Biggers [off-list ref] wrote:

Fix poly1305-armv4.pl to not do '.globl poly1305_blocks_neon' when
poly1305_blocks_neon() is not defined.  Then, remove the empty __weak
definition of poly1305_blocks_neon(), which was still needed only
because of that unnecessary globl statement.  (It also used to be needed
because the compiler could generate calls to it when
CONFIG_KERNEL_MODE_NEON=n, but that has been fixed.)

Thanks to Arnd Bergmann for reporting that the globl statement in the
asm file was still depending on the weak symbol.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
 lib/crypto/arm/poly1305-armv4.pl | 2 +-
 lib/crypto/arm/poly1305-glue.c   | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

Acked-by: Ard Biesheuvel <ardb@kernel.org>