Thread (14 messages) 14 messages, 3 authors, 2025-07-12

Re: [PATCH v2 4/6] arm64: dts: rockchip: Add ArmSoM Sige1

From: Jonas Karlman <jonas@kwiboo.se>
Date: 2025-07-12 15:16:41
Also in: linux-devicetree, linux-rockchip, lkml

Hi,

On 7/12/2025 6:00 AM, Chukun Pan wrote:
Hi,
quoted
quoted
Should this label be named as led-0/led-1?
quoted
The nodes must include 'led' anywhere in their name according to schema:

"""
patternProperties:
  # The first form is preferred, but fall back to just 'led' anywhere in the
  # node name to at least catch some child nodes.
  "(^led-[0-9a-f]$|led)":
"""

Using the color name similar to the the pin labels in schematics made
most sense to me.

Do you want me to change these to conform to the more restricted
^led-[0-9a-f]$ pattern?
This will be better.
Will change the node names of the leds in a v3.
quoted
I only try to enable controllers for devices that are properly described,
so I ignored the pwm-fan and its required pwm6 controller. Mostly
because it make more sense to describe the fan once thermal support is
completed, work [1] currently being blocked by a rk356x otp series [2]
and that depends on a rk3576 thermal series [3].
Ok, I got it. Is usb2.0 also stuck?
USB2.0 is mostly stuck due to my limited time and possible power-domain,
will try to send the USB2.0 patches to mailing list tomorrow.

Regards,
Jonas
Thanks,
Chukun

--
2.25.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help