Re: [PATCH v5 0/6] Add support for S4 audio
From: Jerome Brunet <jbrunet@baylibre.com>
Date: 2025-07-10 09:32:48
Also in:
linux-amlogic, linux-clk, linux-devicetree, linux-sound, lkml
On Thu 10 Jul 2025 at 11:35, jiebing chen via B4 Relay [off-list ref] wrote:
This series completes the end-to-end audio support for S4 SoC from hardware bindings to driver implementation and system integration. 1 Device Tree Bindings Updates Added audio power domain support for S4 SoC.Defined mclk/sclk pad clock IDs in AXG audio bindings. Add S4 audio tocodec binding support. 2 Driver Implementation Implemented S4 tocodec driver for G12A architecture. Add mclk pad divider support for S4 in AXG audio clock. 3 Device Tree Integration Add Amlogic S4 audio subsystem support in arm64 DTS.
Several subsystem in a single patchset spams a lot of people. It is not strictly necessary here. Ideally, one patchset per subsystem please.
Signed-off-by: jiebing chen <redacted> --- Changes in v5: - Fix warning Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yam when make dt_binding_check - The audio reg is mounted below the APB bus in dts file. - Deal with pad clock in a distinct controller. - Fix warning for sound/soc/meson/g12a-toacodec.c - Link to v4: https://lore.kernel.org/r/20250319-audio_drvier-v4-0-686867fad719@amlogic.com (local) Changes in v4: - fix dtb check warning - add maxItems of power domain for dt-bindings - fixed audio clock pads regmap base and reg offset - use dapm widget to control tocodec bclk and mclk enable - Link to v3: https://lore.kernel.org/r/20250228-audio_drvier-v3-0-dbfd30507e4c@amlogic.com (local) Changes in v3: - remove g12a tocodec switch event - Modify the incorrect title for dt-bindings - Link to v2: https://lore.kernel.org/r/20250214-audio_drvier-v2-0-37881fa37c9e@amlogic.com (local) Changes in v2: - remove tdm pad control and change tocodec base on g12a - change hifipll rate to support 24bit - add s4 audio clock - Link to v1: https://lore.kernel.org/r/20250113-audio_drvier-v1-0-8c14770f38a0@amlogic.com (local) --- jiebing chen (6): dt-bindings: clock: meson: Add audio power domain for s4 soc dt-bindings: clock: axg-audio: Add mclk and sclk pad clock ids dt-bindings: Asoc: axg-audio: Add s4 audio tocodec ASoC: meson: g12a-toacodec: Add s4 tocodec driver clk: meson: axg-audio: Add the mclk pad div for s4 chip arm64: dts: amlogic: Add Amlogic S4 Audio .../bindings/clock/amlogic,axg-audio-clkc.yaml | 55 ++- .../bindings/sound/amlogic,g12a-toacodec.yaml | 1 + .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts | 218 +++++++++++ arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 387 ++++++++++++++++++ drivers/clk/meson/axg-audio.c | 435 ++++++++++++++++++++- drivers/clk/meson/axg-audio.h | 6 + include/dt-bindings/clock/axg-audio-clkc.h | 11 + sound/soc/meson/g12a-toacodec.c | 42 ++ 8 files changed, 1152 insertions(+), 3 deletions(-) --- base-commit: 6ecd20965bdc21b265a0671ccf36d9ad8043f5ab change-id: 20250110-audio_drvier-07a5381c494b Best regards,
-- Jerome