Re: [PATCH] firmware: arm_scmi: Use modern PM ops

On Tue, Jul 08, 2025 at 04:19:50PM -0700, Nathan Chancellor wrote:

When building without CONFIG_PM_SLEEP (e.g., with hexagon or s390),
there is a warning because scmi_system_power_resume() is not used due to
how SET_SYSTEM_SLEEP_PM_OPS is defined:

  drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error: 'scmi_system_power_resume' defined but not used [-Werror=unused-function]
    363 | static int scmi_system_power_resume(struct device *dev)
        |            ^~~~~~~~~~~~~~~~~~~~~~~~

Use the moderm SYSTEM_SLEEP_PM_OPS to resolve the warnings, which is
what SET_SYSTEM_SLEEP_PM_OPS ultimately expands to, so there is no
change in behavior.

If it is OK, I plan to pick [1] which additional uses pm_sleep_ptr()
to avoid additional warnings.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/all/20250709070107.1388512-1-arnd@kernel.org (local)