Thread (15 messages) 15 messages, 4 authors, 2025-07-10

Re: [PATCH 4/6] arm64: dts: rockchip: Add ArmSoM Sige1

From: Chukun Pan <hidden>
Date: 2025-07-09 07:00:22
Also in: linux-devicetree, linux-rockchip, lkml

Hi,
+	vcc5v0_usb1_host: regulator-5v0-vcc-usb1-host {
+		compatible = "regulator-fixed";
...
+		regulator-always-on;
+		regulator-boot-on;
...
+	vcc5v0_usb2_host: regulator-5v0-vcc-usb2-host {
+		regulator-always-on;
+		regulator-boot-on;
...
I think these two regulators do not need boot-on?
+	rfkill {
+		compatible = "rfkill-gpio";
+		label = "rfkill-wlan";
+		pinctrl-names = "default";
+		pinctrl-0 = <&wifi_reg_on_h>;
+		radio-type = "wlan";
+		shutdown-gpios = <&gpio1 RK_PA6 GPIO_ACTIVE_HIGH>;
+	};
Why not use mmc-pwrseq instead of rfkill?
+	rfkill-bt {
+		compatible = "rfkill-gpio";
+		label = "rfkill-bt";
+		pinctrl-names = "default";
+		pinctrl-0 = <&bt_reg_on_h>;
+		radio-type = "bluetooth";
+		shutdown-gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>;
+	};
Why not use shutdown-gpios of bcm43438-bt?
+&i2c0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0m0_xfer>;
+	status = "okay";
+
+	hym8563: rtc@51 {
+		compatible = "haoyu,hym8563";
+		reg = <0x51>;
+		#clock-cells = <0>;
+		clock-output-names = "hym8563";
CLKOUT pin is not connected.
+&sdio0 {
+	bus-width = <4>;
+	cap-sd-highspeed;
+	cap-sdio-irq;
+	disable-wp;
+	keep-power-in-suspend;
+	no-mmc;
+	no-sd;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdio0_bus4>, <&sdio0_clk>, <&sdio0_cmd>, <&clkm1_32k_out>;
I recommend using clkm1_32k_out at the sdio-pwrseq node.
+	sd-uhs-sdr104;
+	vmmc-supply = <&vcc_3v3>;
+	vqmmc-supply = <&vcc_1v8>;
+	status = "okay";
Maybe `brcm,bcm4329-fmac` nodes can be added here?
+&uart2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart2m1_xfer>, <&uart2m1_ctsn>, <&uart2m1_rtsn>;
+	uart-has-rtscts;
+	status = "okay";
You can add `brcm,bcm43438-bt` nodes here:

	bluetooth {
		compatible = "brcm,bcm43438-bt";
		device-wakeup-gpios = <&gpio3 RK_PC3 GPIO_ACTIVE_HIGH>;
		host-wakeup-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
		shutdown-gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>;
		...
	};

Thanks,
Chukun

--
2.25.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help