Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3

On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote:

Le 01/07/2025 à 16:36, Matthias Schiffer a écrit :

quoted

On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote:

quoted

After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver
select on ARCH_K3 are not needed anymore.
Select MAILBOX by default is not needed anymore[3],
PM_GENERIC_DOMAIN if PM was enabled by default so not needed.

Hi,

Hi,

quoted

what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot
on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have
not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without
enabling other unneeded features to pull it in.

With master branch if i apply this patch and i do make ARCH=arm64 
defconfig and check in .config  both TI_SCI_PM_DOMAINS and 
PM_GENERIC_DOMAINS are enabled.
with linux-next it's same. i don't really understand link with  PM part 
in this patch and boot issue on your SOM.

I probably misunderstand something.


what is your problem exactly ?

if you can share log or link to jobs

Hi Guillaume,

with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols
also have "select PM_GENERIC_DOMAINS" (with or without "if PM").

We are using a smaller config specific to our K3-based SOMs however. I have
attached a defconfig that shows the problem - if you use this as the base for
.config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing
selects PM_GENERIC_DOMAINS.

So unless I'm missing some other configuration that would actually be useful on
the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part
needs to be reverted. I can send a patch to that effect later.

Best,
Matthias

Regards
Guillaume

quoted

Best,
Matthias

quoted

Remove it and give possibility to enable this driver in modules.

[1] https://lore.kernel.org/all/20180828005311.8529-1-nm@ti.com/ (local)
[2] https://lore.kernel.org/all/20250220-ti-firmware-v2-1-ff26883c6ce9@baylibre.com/ (local)
[3] https://lore.kernel.org/all/20250507135213.g6li6ufp3cosxoys@stinging/ (local)

Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
Changes in v2:
- Remove some other config after comment from Nishanth.
- Link to v1: https://lore.kernel.org/r/20250504-kconfig-v1-1-ab0216f4fa98@baylibre.com (local)
---
  arch/arm64/Kconfig.platforms | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 8b76821f190f..bf9e3d76b4c0 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms

@@ -135,11 +135,7 @@ config ARCH_SPARX5
  
  config ARCH_K3
  	bool "Texas Instruments Inc. K3 multicore SoC architecture"
-	select PM_GENERIC_DOMAINS if PM
-	select MAILBOX
  	select SOC_TI
-	select TI_MESSAGE_MANAGER
-	select TI_SCI_PROTOCOL
  	select TI_K3_SOCINFO
  	help
  	  This enables support for Texas Instruments' K3 multicore SoC

---
base-commit: e8ab83e34bdc458b5cd77f201e4ed04807978fb1
change-id: 20250504-kconfig-68f139fbf337

Best regards,

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/