Re: [PATCH 2/6] thermal/drivers/sun8i: replace devm_reset_control_get to shared
From: Chen-Yu Tsai <hidden>
Date: 2025-06-30 04:54:09
Also in:
linux-devicetree, linux-pm, linux-sunxi, lkml
On Fri, Apr 11, 2025 at 8:39 AM iuncuim [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Mikhail Kalashnikov <redacted> The A523 processor has two temperature controllers, but they share a common reset line. We need to use devm_reset_control_get_shared() instead of devm_reset_control_get() Signed-off-by: Mikhail Kalashnikov <redacted> --- drivers/thermal/sun8i_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c index 1f3908a60..dc4055c9c 100644 --- a/drivers/thermal/sun8i_thermal.c +++ b/drivers/thermal/sun8i_thermal.c@@ -391,7 +391,7 @@ static int sun8i_ths_resource_init(struct ths_device *tmdev) return PTR_ERR(tmdev->regmap); if (tmdev->chip->has_bus_clk_reset) { - tmdev->reset = devm_reset_control_get(dev, NULL); + tmdev->reset = devm_reset_control_get_shared(dev, NULL);
You could just use devm_reset_control_get_shared_deasserted() and then drop the reset_control_deassert() and devm_add_action_or_reset() stuff below this hunk. This simplifies the driver a bit.
if (IS_ERR(tmdev->reset))
return PTR_ERR(tmdev->reset);
--
2.49.0