Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
From: Rui Miguel Silva <rmfrfs@gmail.com>
Date: 2025-06-25 16:04:41
Also in:
imx, kernel-janitors, linux-media, lkml
Hey Dan, Thanks for the patch. On Wed Jun 25, 2025 at 4:22 PM WEST, Dan Carpenter wrote:
This was returning IS_ERR() where PTR_ERR() was intended.
Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
Signed-off-by: Dan Carpenter <redacted>
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Cheers,
Rui
quoted hunk ↗ jump to hunk
--- drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c index 6501843ae72d..3a4645f59a44 100644 --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c@@ -966,7 +966,7 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *state) base = devm_platform_ioremap_resource(to_platform_device(dev), 1); if (IS_ERR(base)) - return dev_err_probe(dev, IS_ERR(base), "Missing CSR register\n"); + return dev_err_probe(dev, PTR_ERR(base), "Missing CSR register\n"); state->phy_gpr = devm_regmap_init_mmio(dev, base, ®map_config); if (IS_ERR(state->phy_gpr))-- 2.47.2