Thread (25 messages) 25 messages, 5 authors, 2025-07-10

Re: [PATCH net 1/4] auxiliary: Allow empty id

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2025-06-20 05:13:24
Also in: lkml, netdev

On Thu, Jun 19, 2025 at 04:05:34PM -0400, Sean Anderson wrote:
Support creating auxiliary devices with the id included as part of the
name. This allows for non-decimal ids, which may be more appropriate for
auxiliary devices created as children of memory-mapped devices. For
example, a name like "xilinx_emac.mac.802c0000" could be achieved by
setting .name to "mac.802c0000" and .id to AUXILIARY_DEVID_NONE.
I don't see the justification for this, sorry.  An id is just an id, it
doesn't matter what is is and nothing should be relying on it to be the
same across reboots or anywhere else.  The only requirement is that it
be unique at this point in time in the system.

We're having this same discussion on a different thread for a different
bus as well.  This isn't something new, it's been hashed out and
resolved 20+ years ago...

So no, this change isn't ok to make at this point in time, sorry.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help