Re: [PATCH v3 1/1] dt-bindings: mmc: mxs-mmc: change ref to mmc-controller-common.yaml from mmc-controller.yaml
From: Ulf Hansson <hidden>
Date: 2025-06-19 11:20:31
Also in:
imx, linux-devicetree, linux-mmc, lkml
On Tue, 3 Jun 2025 at 17:23, Frank Li [off-list ref] wrote:
Change ref to mmc-controller-common.yaml from mmc-controller.yaml because imx23/imx28 use dual mode controller (spi and mmc). So default dts node name use spi instead of mmc. The legacy reason, it use difference compatible string to distringuish work mode (spi / mmc). Fix below CHECK_DTB warnings: arch/arm/boot/dts/nxp/mxs/imx23-olinuxino.dtb: spi@80010000 (fsl,imx23-mmc): $nodename:0: 'spi@80010000' does not match '^mmc(@.*)?$' Additional add clocks property. Signed-off-by: Frank Li <Frank.Li@nxp.com>
Applied for next, thanks! Kind regards Uffe
quoted hunk ↗ jump to hunk
--- change in v3 - add clocks in example to fix dt_binding_check warnings/errors. change in v2 - add clocks to required - fix typo legancy in commit message --- Documentation/devicetree/bindings/mmc/mxs-mmc.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml b/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml index 32e512a68ed61..df07ea3b81d15 100644 --- a/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml +++ b/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml@@ -17,7 +17,7 @@ description: | and the properties used by the mxsmmc driver. allOf: - - $ref: mmc-controller.yaml + - $ref: mmc-controller-common.yaml# properties: compatible:@@ -31,6 +31,9 @@ properties: interrupts: maxItems: 1 + clocks: + maxItems: 1 + dmas: maxItems: 1@@ -41,6 +44,7 @@ required: - compatible - reg - interrupts + - clocks - dmas - dma-names@@ -52,6 +56,7 @@ examples: compatible = "fsl,imx28-mmc"; reg = <0x80010000 2000>; interrupts = <96>; + clocks = <&clks 46>; dmas = <&dma_apbh 0>; dma-names = "rx-tx"; bus-width = <8>; --2.34.1