Re: [PATCH v4 01/13] dt-bindings: net: mediatek,net: update for mt7988

Am 17. Juni 2025 17:13:54 MESZ schrieb Rob Herring [off-list ref]:

On Mon, Jun 16, 2025 at 11:58:11AM +0200, Frank Wunderlich wrote:

quoted

From: Frank Wunderlich <redacted>

Update binding for mt7988 which has 3 gmac and 2 reg items.

With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names
to make them accessible by name.

Signed-off-by: Frank Wunderlich <redacted>
---
v4:
- increase max interrupts to 8 because of RSS/LRO interrupts

But the schema says 6?

Yes it was an error in changelog,see mail i
 sent later to you and ML. 8 was previously
 because original version had 2 reserved irqs
 around rx+tx i dropped later by using
 irq-names.

See my patch introducing irq-names in mtk
eth driver:

<https://patchwork.kernel.org/project/linux-mediatek/patch/20250616080738.117993-2-linux@fw-web.de/>

Original (downstream/sdk) was (but 
index-based):

rsv
rx
tx
rsv/misc
rx-ring0
...
rx-ring3

So total 8 and i don't wanted to add 2 
reserved irq to dts forever so i decided
moving to irq-names now.

quoted

- dropped Robs RB due to this change
- allow interrupt names
- add interrupt-names without reserved IRQs on mt7988
  this requires mtk driver patch:
  https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/

v2:
- change reg to list of items
---
 .../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++---
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 9e02fd80af83..f8025f73b1cb 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml

@@ -28,7 +28,10 @@ properties:
       - ralink,rt5350-eth
 
   reg:
-    maxItems: 1
+    items:
+      - description: Register for accessing the MACs.
+      - description: SoC internal SRAM used for DMA operations.
+    minItems: 1
 
   clocks:
     minItems: 2

@@ -40,7 +43,11 @@ properties:
 
   interrupts:
     minItems: 1
-    maxItems: 4
+    maxItems: 6
+
+  interrupt-names:
+    minItems: 1
+    maxItems: 6
 
   power-domains:
     maxItems: 1

@@ -348,7 +355,17 @@ allOf:
     then:
       properties:
         interrupts:
-          minItems: 4
+          minItems: 2
+
+        interrupt-names:
+          minItems: 2
+          items:
+            - const: tx
+            - const: rx
+            - const: rx-ring0
+            - const: rx-ring1
+            - const: rx-ring2
+            - const: rx-ring3
 
         clocks:
           minItems: 24

@@ -381,8 +398,11 @@ allOf:
             - const: xgp2
             - const: xgp3
 
+        reg:
+          minItems: 2
+
 patternProperties:
-  "^mac@[0-1]$":
+  "^mac@[0-2]$":
     type: object
     unevaluatedProperties: false
     allOf:

-- 
2.43.0

regards Frank