Re: [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees

Le Fri, 13 Jun 2025 13:52:23 -0500,
Jason Kridner [off-list ref] a écrit :

On Fri, Jun 13, 2025 at 10:49 AM Kory Maincent [off-list ref]
wrote:

quoted

Several device trees incorrectly included extraneous compatible strings
in their compatible property lists. The policy is to only describe the
specific board name and SoC name to avoid confusion.

Remove these incorrect compatible strings to fix the inconsistency.

Also fix board vendor prefixes for BeagleBoard variants that were
incorrectly using "ti" instead of "beagle" or "seeed".

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v3:
- Remove extraneous compatible strings.
- Replace BeagleBone board name vendor.

Changes in v2:
- New patch
---
 arch/arm/boot/dts/ti/omap/am335x-base0033.dts                   | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-bone.dts                       | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts         | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-boneblack.dts                  | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-boneblue.dts                   | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts         | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts                  | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts                 | 3 +--
 arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts               | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts             | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts               | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts          | 5 +----
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts               | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-shc.dts                        | 2 +-
 15 files changed, 22 insertions(+), 29 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts

b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
index 46078af4b7a3..176de29de2a6 100644

--- a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts

@@ -9,7 +9,7 @@

 / {
        model = "IGEP COM AM335x on AQUILA Expansion";
-       compatible = "isee,am335x-base0033", "isee,am335x-igep0033",

"ti,am33xx";
+       compatible = "isee,am335x-base0033", "ti,am33xx";

        hdmi {
                compatible = "ti,tilcdc,slave";

diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone.dts

b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
index b5d85ef51a02..2790c0c5a473 100644

--- a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bone.dts

@@ -8,8 +8,8 @@
 #include "am335x-bone-common.dtsi"

 / {
-       model = "TI AM335x BeagleBone";
-       compatible = "ti,am335x-bone", "ti,am33xx";
+       model = "AM335x BeagleBone";  

We have software that looks at these in running systems, so I’d be ok not
to change. If changing, why not “BeagleBoard.org BeagleBone”? Not sure of
the convention to mention the SoC, but AM335x is not part of the product
name.

Is it ok to change it or not then? Ok to move on to BeagleBoard.org.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com