Thread (34 messages) 34 messages, 4 authors, 2025-06-16

Re: [PATCH 07/16] crypto: sha512 - replace sha512_generic with wrapper around SHA-512 library

From: Ard Biesheuvel <ardb@kernel.org>
Date: 2025-06-13 07:38:26
Also in: linux-crypto, linux-mips, linux-riscv, linux-s390, lkml, sparclinux

On Fri, 13 Jun 2025 at 07:55, Eric Biggers [off-list ref] wrote:
On Fri, Jun 13, 2025 at 01:38:59PM +0800, Herbert Xu wrote:
quoted
On Thu, Jun 12, 2025 at 10:36:24PM -0700, Eric Biggers wrote:
quoted
You do know that most of the sha512 asynchronous hash drivers use custom state
formats and not your new one, right?  So your code in ahash_do_req_chain() is
broken for most asynchronous hash drivers anyway.
Every driver needs to be converted by hand.  Once a driver has
been converted it'll be marked as block-only which activates
the fallback path in ahash.
Perhaps I am just slow, but could you please explain again what the
point is of all these changes?

Where is h/w accelerated ahash being used to the extent that it
justifies changing all this existing code to accommodate it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help