Thread (8 messages) 8 messages, 2 authors, 2025-06-10

Re: [PATCH 2/2] tpm: tpm_crb_ffa: maunally register tpm_crb_ffa driver when it's built-in

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2025-06-10 12:17:23
Also in: linux-integrity, lkml

On Fri, Jun 06, 2025 at 07:12:43PM +0100, Yeoreum Yun wrote:
Hi Jarkko,
quoted
quoted
To integrate tpm_event_log with IMA subsystem,
tpm_crb and tpm_crb_ffa driver should be built as built-in
(CONFIG_TCG_CRB=y && CONFIG_TCG_CRB_FFA=y).

However, this could make failure for ima_init() gets tpm chip when
each initcall function deployed like:

0000000000000888 l       .initcall6.init	0000000000000000 crb_acpi_driver_init
000000000000088c l       .initcall6.init	0000000000000000 tpm_crb_ffa_driver_init
The only failure I see is the patch 1/2 which changes init call level,
and leaves kernel Git to a broken state.

It breaks the famous "zero regressions policy".

BR, Jarkko
Sorry, would you let me know what is broken more detail?
IMHO, by changing the init call level for ffa_init()
it's called early than before device_initcall() and it seems not to
break anything.

What breaks do you mean?
Let's start from very beginning. Why this change is needed and not just
1/2?

IMA intializes as a late initcall, which after TPM has initialized.
Thanks.

--
Sincerely,
Yeoreum Yun
BR, Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help