Thread (3 messages) 3 messages, 2 authors, 2025-06-10

Re: [PATCH] drm/meson: use vclk_freq instead of pixel_freq in debug print

From: neil.armstrong@linaro.org
Date: 2025-06-09 17:34:15
Also in: dri-devel, linux-amlogic, lkml

On 07/06/2025 00:10, Martin Blumenstingl wrote:
quoted hunk ↗ jump to hunk
meson_vclk_vic_supported_freq() has a debug print which includes the
pixel freq. However, within the whole function the pixel freq is
irrelevant, other than checking the end of the params array. Switch to
printing the vclk_freq which is being compared / matched against the
inputs to the function to avoid confusion when analyzing error reports
from users.

Fixes: e5fab2ec9ca4 ("drm/meson: vclk: add support for YUV420 setup")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
  drivers/gpu/drm/meson/meson_vclk.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c
index 3325580d885d..c4123bb958e4 100644
--- a/drivers/gpu/drm/meson/meson_vclk.c
+++ b/drivers/gpu/drm/meson/meson_vclk.c
@@ -790,9 +790,9 @@ meson_vclk_vic_supported_freq(struct meson_drm *priv,
  	}
  
  	for (i = 0 ; params[i].pixel_freq ; ++i) {
-		DRM_DEBUG_DRIVER("i = %d pixel_freq = %lluHz alt = %lluHz\n",
-				 i, params[i].pixel_freq,
-				 PIXEL_FREQ_1000_1001(params[i].pixel_freq));
+		DRM_DEBUG_DRIVER("i = %d vclk_freq = %lluHz alt = %lluHz\n",
+				 i, params[i].vclk_freq,
+				 PIXEL_FREQ_1000_1001(params[i].vclk_freq));
  		DRM_DEBUG_DRIVER("i = %d phy_freq = %lluHz alt = %lluHz\n",
  				 i, params[i].phy_freq,
  				 PHY_FREQ_1000_1001(params[i].phy_freq));
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help