Thread (18 messages) 18 messages, 6 authors, 2025-06-25

Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2025-06-05 22:42:27
Also in: linux-devicetree, linux-pci, lkml

On 6/5/25 15:36, Rob Herring wrote:
On Tue, Jun 03, 2025 at 10:17:26AM -0700, Florian Fainelli wrote:
quoted
On 6/3/25 10:16, Jim Quinlan wrote:
quoted
On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
[off-list ref] wrote:
quoted
On 5/30/25 16:32, Florian Fainelli wrote:
quoted
On 5/30/25 15:40, Jim Quinlan wrote:
quoted
Add optional num-lanes property Broadcom STB PCIe host controllers.

Signed-off-by: Jim Quinlan <redacted>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Sorry I take that back, I think this should be:

num-lanes:
     enum: [ 1, 2, 4 ]

We are basically documenting the allowed values, not specifying that we
can repeat the num-lames property between 1 and 4 times.
Are you confused with maxItems?
Yes I am.
quoted
quoted
num-lanes is already defined as

      enum: [ 1, 2, 4, 8, 16, 32 ]
Right, but then we need to re-define it with our own specific constraints,
still, don't we?
It is correct as-is.
Thanks!
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help