Re: [PATCH] PM / devfreq: sun8i-a33-mbus: Fix misconversion to devm_clk_rate_exclusive_get()
From: Chanwoo Choi <chanwoo@kernel.org>
Date: 2025-05-13 16:31:44
Also in:
linux-pm, linux-sunxi, oe-kbuild-all
Hi, Instead of fix-up patch, I'd like you to send the v2 of patch[1]. [1] https://patchwork.kernel.org/project/linux-pm/patch/20241111112237.336310-2-u.kleine-koenig@baylibre.com/ On Mon, May 12, 2025 at 5:29 PM Uwe Kleine-König [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The patch converting the driver to make more use of devm functions got one conversion wrong making the driver not compilable any more. I have no excuse, mea culpa! Fix this by adding the needed device parameter. Reported-by: kernel test robot <redacted> Link: https://lore.kernel.org/all/202412070231.MzXdNrLv-lkp@intel.com (local) Fixes: bc253b28a365 ("PM / devfreq: sun8i-a33-mbus: Simplify by using more devm functions") Signed-off-by: Uwe Kleine-König <redacted> --- drivers/devfreq/sun8i-a33-mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/devfreq/sun8i-a33-mbus.c b/drivers/devfreq/sun8i-a33-mbus.c index f99af530211d..4bd5657558d6 100644 --- a/drivers/devfreq/sun8i-a33-mbus.c +++ b/drivers/devfreq/sun8i-a33-mbus.c@@ -381,7 +381,7 @@ static int sun8i_a33_mbus_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, "failed to lock dram clock rate\n"); /* Lock the MBUS clock rate to keep MBUS_TMR_PERIOD in sync. */ - ret = devm_clk_rate_exclusive_get(priv->clk_mbus); + ret = devm_clk_rate_exclusive_get(dev, priv->clk_mbus); if (ret) return dev_err_probe(dev, ret, "failed to lock mbus clock rate\n"); --2.47.2
-- Best Regards, Chanwoo Choi Samsung Electronics