RE: [PATCH 05/10] PCI: exynos: Add structure to hold resource operations
From: Shradha Todi <hidden>
Date: 2025-05-28 04:53:10
Also in:
linux-devicetree, linux-pci, linux-phy, lkml
-----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: 21 May 2025 15:13 To: Shradha Todi <redacted> Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.or; linux-kernel@vger.kernel.org; linux-phy@lists.infradead.org; manivannan.sadhasivam@linaro.org; lpieralisi@kernel.org; kw@linux.com; robh@kernel.org; bhelgaas@google.com; jingoohan1@gmail.com; krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; vkoul@kernel.org; kishon@kernel.org; arnd@arndb.de; m.szyprowski@samsung.com; jh80.chung@samsung.com; Pankaj Dubey [off-list ref] Subject: Re: [PATCH 05/10] PCI: exynos: Add structure to hold resource operations On Mon, May 19, 2025 at 01:01:47AM GMT, Shradha Todi wrote:quoted
+struct samsung_res_ops { + int (*init_regulator)(struct exynos_pcie *ep); + irqreturn_t (*pcie_irq_handler)(int irq, void *arg); }; static void exynos_pcie_writel(void __iomem *base, u32 val, u32 reg)@@ -74,6 +81,36 @@ static u32 exynos_pcie_readl(void __iomem *base, u32 reg) return readl(base + reg); } +static int samsung_regulator_enable(struct exynos_pcie *ep) { + struct device *dev = ep->pci.dev; + int ret; + + if (ep->supplies_cnt == 0) + return 0; + + ret = devm_regulator_bulk_get(dev, ep->supplies_cnt, ep->supplies);No. Getting resources on every enable is making this much less readable. NAK
Will make sure that we get the resources only once during probe.
Best regards, Krzysztof