Re: [PATCH v6 1/4] dt-bindings: can: rockchip_canfd: add rk3576 CAN-FD controller
From: Conor Dooley <conor@kernel.org>
Date: 2025-05-26 15:12:35
Also in:
linux-can, linux-devicetree, linux-rockchip, lkml
On Mon, May 26, 2025 at 02:25:56PM +0800, Elaine Zhang wrote:
quoted hunk ↗ jump to hunk
Add documentation for the rockchip rk3576 CAN-FD controller. Signed-off-by: Elaine Zhang <redacted> --- .../net/can/rockchip,rk3568v2-canfd.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+)diff --git a/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml index a077c0330013..c6595fef6cb5 100644 --- a/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml +++ b/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml@@ -12,11 +12,27 @@ maintainers: allOf: - $ref: can-controller.yaml# + - if: + properties: + compatible: + contains: + const: rockchip,rk3576-canfd + required: + - compatible + then: + required: + - dmas + - dma-names + else: + properties: + dmas: false + dma-names: false
Once the allOf contains more than just an include it should be moved down below the properties that it is constraining. Otherwise, I think this looks fine.
quoted hunk ↗ jump to hunk
properties: compatible: oneOf: - const: rockchip,rk3568v2-canfd + - const: rockchip,rk3576-canfd - items: - const: rockchip,rk3568v3-canfd - const: rockchip,rk3568v2-canfd@@ -43,6 +59,13 @@ properties: - const: core - const: apb + dmas: + maxItems: 1 + + dma-names: + items: + - const: rx + required: - compatible - reg@@ -72,3 +95,21 @@ examples: reset-names = "core", "apb"; }; }; + + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + can@2ac00000 { + compatible = "rockchip,rk3576-canfd"; + reg = <0x0 0x2ac00000 0x0 0x1000>; + interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru CLK_CAN0>, <&cru PCLK_CAN0>; + clock-names = "baud", "pclk"; + resets = <&cru SRST_CAN0>, <&cru SRST_P_CAN0>; + reset-names = "core", "apb"; + dmas = <&dmac0 20>; + dma-names = "rx"; + }; + };-- 2.34.1
Attachments
- signature.asc [application/pgp-signature] 228 bytes