Re: [PATCH v1] arm64: dts: amlogic: Update USB hub power and reset properties

Hi Neil,

On Tue, 20 May 2025 at 18:02, Neil Armstrong [off-list ref] wrote:

On 20/05/2025 11:18, Anand Moon wrote:

quoted

Add missing reset-gpios property to the USB 2.0 hub node to
ensure proper reset handling. Also update the vdd-supply for
both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
for consistent power management.

Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by: Anand Moon <redacted>
---
  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 3bca8023638d..ad959f8bc1ac 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
                      compatible = "usb5e3,610";
                      reg = <1>;
                      peer-hub = <&hub_3_0>;
-                     vdd-supply = <&usb_pwr_en>;
+                     reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+                     vdd-supply = <&hub_5v>;
              };

              /* 3.0 hub on port 4 */

@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
                      reg = <2>;
                      peer-hub = <&hub_2_0>;
                      reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-                     vdd-supply = <&vcc_5v>;
+                     vdd-supply = <&hub_5v>;

In this case, also remove the &usb2_phy1 phy-supply since now it's managed by the hub reset control.

Ok I will update in the next version.

Neil

Thank
-Anand