Re: [PATCH v5 03/10] dt-bindings: mfd: Add Apple Mac System Management Controller
From: Rob Herring <robh@kernel.org>
Date: 2025-05-14 20:55:02
Also in:
asahi, linux-devicetree, linux-gpio, linux-pm, lkml
On Sun, May 11, 2025 at 08:18:38AM +0000, Sven Peter wrote:
quoted hunk ↗ jump to hunk
From: "Russell King (Oracle)" <redacted> Add a DT binding for the Apple Mac System Management Controller. Signed-off-by: Russell King (Oracle) <redacted> Reviewed-by: Linus Walleij <redacted> Reviewed-by: Krzysztof Kozlowski <redacted> Reviewed-by: Alyssa Rosenzweig <redacted> Signed-off-by: Sven Peter <redacted> --- .../devicetree/bindings/mfd/apple,smc.yaml | 71 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 72 insertions(+)diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml new file mode 100644 index 0000000000000000000000000000000000000000..9f1058c15bbf62d84f8a72fdaa354909b02e2801 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml@@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple Mac System Management Controller + +maintainers: + - Sven Peter <sven@svenpeter.dev> + +description: + Apple Mac System Management Controller implements various functions + such as GPIO, RTC, power, reboot. + +properties: + compatible: + items: + - enum: + - apple,t6000-smc + - apple,t8103-smc + - apple,t8112-smc + - const: apple,smc + + reg: + items: + - description: SMC area + - description: SRAM area + + reg-names: + items: + - const: smc + - const: sram + + mboxes: + maxItems: 1 + + gpio: + $ref: /schemas/gpio/apple,smc-gpio.yaml + + reboot: + $ref: /schemas/power/reset/apple,smc-reboot.yaml + +additionalProperties: false + +required: + - compatible + - reg + - reg-names + - mboxes + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + smc@23e400000 { + compatible = "apple,t8103-smc", "apple,smc"; + reg = <0x2 0x3e400000 0x0 0x4000>, + <0x2 0x3fe00000 0x0 0x100000>; + reg-names = "smc", "sram"; + mboxes = <&smc_mbox>; + + smc_gpio: gpio { + compatible = "apple,smc-gpio"; + gpio-controller; + #gpio-cells = <2>; + }; + };
If there's another version, please make the example here complete and drop the other incomplete examples in the child bindings. Rob