Hi Peng,

On Mon, May 12, 2025 at 12:56:13PM +0800, Peng Fan wrote:

Ulf's new API dev_pm_genpd_is_on needs to run after power domain attached.

But if run after power domain attached, there is no API to know whether
M4 is kicked by bootloader or now.

Even imx_rproc_attach_pd has a check for single power domain, but I just
give a look again on current i.MX8QM/QX, all are using two power domain
entries.

quoted

quoted

In this way we don't need to export unnecessary firmware functions
from firmware/imx/misc.c, as patch1/3 does.

I think still need to export firmware API. My idea is
1. introduce a new firmware API and put under firmware/imx/power.c
2. Use this new firmware API in imx_rproc.c
3. Replace scu-pd.c to use this new firmware API.

Or
1. Export the API in scu-pd.c
2. Use the API in imx_rproc.c

With approach two, you need to handle them in three trees in one patchset:
imx/pd/rproc.

With approach one, you need to handle two trees in one patchset: imx/rproc tree,
then after done, pd tree

This patch series is already implementing approach one, as I understand,
right?

The difference is I moved this API from drivers/pmdomain/imx/scu-pd.c to
firmware/imx/misc.c, and exported it there. But you think I should
create this new file firmware/imx/power.c and move the API from scu-pd.c
to power.c, is my understanding correct?

Regards,
Peng

Best Regards,
Hiago.