On Sat, May 10, 2025 at 11:04:55AM +1000, Stephen Rothwell wrote:

Hi Alexei,

On Fri, 9 May 2025 10:04:18 -0700 Alexei Starovoitov [off-list ref] wrote:

quoted

On Fri, May 9, 2025 at 5:24 AM Saket Kumar Bhaskar [off-list ref] wrote:

quoted

On linux-next, build for bpf selftest displays an error due to
mismatch in the expected function signature of bpf_testmod_test_read
and bpf_testmod_test_write.

Commit 97d06802d10a ("sysfs: constify bin_attribute argument of bin_attribute::read/write()")
changed the required type for struct bin_attribute to const struct bin_attribute.

To resolve the error, update corresponding signature for the callback.

Reported-by: Venkat Rao Bagalkote <redacted>
Closes: https://lore.kernel.org/all/e915da49-2b9a-4c4c-a34f-877f378129f6@linux.ibm.com/ (local)
Signed-off-by: Saket Kumar Bhaskar <redacted>
---
 tools/testing/selftests/bpf/test_kmods/bpf_testmod.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c
index 2e54b95ad898..194c442580ee 100644
--- a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c
+++ b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c

@@ -385,7 +385,7 @@ int bpf_testmod_fentry_ok;

 noinline ssize_t
 bpf_testmod_test_read(struct file *file, struct kobject *kobj,
-                     struct bin_attribute *bin_attr,
+                     const struct bin_attribute *bin_attr,
                      char *buf, loff_t off, size_t len)  

You didn't even compile it :(

Instead of fixing the build, it breaks the build.

pw-bot: cr

This patch is only needed in linux-next.  It should be applied to the
driver-core tree - since that includes commit 97d06802d10a.  It should
also have a Fixes tag referencing commit 97d06802d10a.
-- 
Cheers,
Stephen Rothwell

Hi Stephen,

Apologies for missing the Fixes tag. Would you like me to resend the patch with the 
Fixes tag included?

Thanks,
Saket