Hi,

On Fri, May 2, 2025 at 3:11 PM Robin Murphy [off-list ref] wrote:

On 02/05/2025 10:59 am, Jens Wiklander wrote:

quoted

Export the global variable dma_contiguous_default_area so
dev_get_cma_area() can be called a module.

What dma_map_ops implementation is in a module? Without any other
context, I can't help thinking this smells of something sketchy.

I see that you found the rest of the patch set
https://lore.kernel.org/lkml/20250502100049.1746335-1-jens.wiklander@linaro.org/ (local)

Thanks,
Jens

Thanks,
Robin.

quoted

Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux.dev
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
---
  kernel/dma/contiguous.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
index 8df0dfaaca18..eb361794a9c5 100644
--- a/kernel/dma/contiguous.c
+++ b/kernel/dma/contiguous.c

@@ -53,6 +53,7 @@
  #endif

  struct cma *dma_contiguous_default_area;
+EXPORT_SYMBOL(dma_contiguous_default_area);

  /*
   * Default global CMA area size can be defined in kernel's .config.