Thread (5 messages) 5 messages, 3 authors, 2025-05-01

Re: [PATCH] clk: sunxi-ng: fix order of arguments in clock macro

From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2025-05-01 05:05:22
Also in: linux-clk, linux-sunxi, lkml

Dne sreda, 30. april 2025 ob 11:53:25 Srednjeevropski poletni čas je Andre Przywara napisal(a):
When introducing the SUNXI_CCU_MP_DATA_WITH_MUX_GATE_FEAT macro, the order
of the last two arguments was different between the users and the
definition: features became flags and flags became features.

This just didn't end up in a desaster yet because most users ended up
passing 0 for both arguments, and other clocks (for the new A523 SoC) are
not yet used.

Swap the order of the arguments in the definition, so that users stay
untouched.

Fixes: cdbb9d0d09db ("clk: sunxi-ng: mp: provide wrappers for setting feature flags")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help