Re: [PATCH net-next v2 7/8] net: phy: move PHY package related code from phy.h to phy_package.c
From: kernel test robot <hidden>
Date: 2025-03-01 19:26:09
Also in:
linux-arm-msm, linux-mediatek, netdev, oe-kbuild-all
Hi Heiner, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heiner-Kallweit/net-phy-move-PHY-package-code-from-phy_device-c-to-own-source-file/20250301-055302 base: net-next/main patch link: https://lore.kernel.org/r/edba99c5-0f95-40bd-8398-98d811068369%40gmail.com patch subject: [PATCH net-next v2 7/8] net: phy: move PHY package related code from phy.h to phy_package.c config: loongarch-randconfig-001-20250302 (https://download.01.org/0day-ci/archive/20250302/202503020328.FJG7PJon-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503020328.FJG7PJon-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202503020328.FJG7PJon-lkp@intel.com/ (local) All errors (new ones prefixed by >>): drivers/net/phy/bcm54140.c: In function 'bcm54140_base_read_rdb': drivers/net/phy/bcm54140.c:436:15: error: implicit declaration of function '__phy_package_write'; did you mean '__phy_package_write_mmd'? [-Wimplicit-function-declaration] 436 | ret = __phy_package_write(phydev, BCM54140_BASE_ADDR, | ^~~~~~~~~~~~~~~~~~~ | __phy_package_write_mmd drivers/net/phy/bcm54140.c:441:15: error: implicit declaration of function '__phy_package_read'; did you mean '__phy_package_read_mmd'? [-Wimplicit-function-declaration] 441 | ret = __phy_package_read(phydev, BCM54140_BASE_ADDR, | ^~~~~~~~~~~~~~~~~~ | __phy_package_read_mmd drivers/net/phy/bcm54140.c: In function 'bcm54140_probe':
quoted
drivers/net/phy/bcm54140.c:599:13: error: implicit declaration of function 'phy_package_init_once'; did you mean 'phy_package_write_mmd'? [-Wimplicit-function-declaration]
599 | if (phy_package_init_once(phydev)) {
| ^~~~~~~~~~~~~~~~~~~~~
| phy_package_write_mmd
vim +599 drivers/net/phy/bcm54140.c
6937602ed3f9ebd Michael Walle 2020-04-20 578
6937602ed3f9ebd Michael Walle 2020-04-20 579 static int bcm54140_probe(struct phy_device *phydev)
6937602ed3f9ebd Michael Walle 2020-04-20 580 {
6937602ed3f9ebd Michael Walle 2020-04-20 581 struct bcm54140_priv *priv;
6937602ed3f9ebd Michael Walle 2020-04-20 582 int ret;
6937602ed3f9ebd Michael Walle 2020-04-20 583
6937602ed3f9ebd Michael Walle 2020-04-20 584 priv = devm_kzalloc(&phydev->mdio.dev, sizeof(*priv), GFP_KERNEL);
6937602ed3f9ebd Michael Walle 2020-04-20 585 if (!priv)
6937602ed3f9ebd Michael Walle 2020-04-20 586 return -ENOMEM;
6937602ed3f9ebd Michael Walle 2020-04-20 587
6937602ed3f9ebd Michael Walle 2020-04-20 588 phydev->priv = priv;
6937602ed3f9ebd Michael Walle 2020-04-20 589
6937602ed3f9ebd Michael Walle 2020-04-20 590 ret = bcm54140_get_base_addr_and_port(phydev);
6937602ed3f9ebd Michael Walle 2020-04-20 591 if (ret)
6937602ed3f9ebd Michael Walle 2020-04-20 592 return ret;
6937602ed3f9ebd Michael Walle 2020-04-20 593
dc9989f173289f3 Michael Walle 2020-05-06 594 devm_phy_package_join(&phydev->mdio.dev, phydev, priv->base_addr, 0);
dc9989f173289f3 Michael Walle 2020-05-06 595
4406d36dfdf1fbd Michael Walle 2020-04-20 596 #if IS_ENABLED(CONFIG_HWMON)
4406d36dfdf1fbd Michael Walle 2020-04-20 597 mutex_init(&priv->alarm_lock);
4406d36dfdf1fbd Michael Walle 2020-04-20 598
dc9989f173289f3 Michael Walle 2020-05-06 @599 if (phy_package_init_once(phydev)) {
4406d36dfdf1fbd Michael Walle 2020-04-20 600 ret = bcm54140_probe_once(phydev);
4406d36dfdf1fbd Michael Walle 2020-04-20 601 if (ret)
4406d36dfdf1fbd Michael Walle 2020-04-20 602 return ret;
4406d36dfdf1fbd Michael Walle 2020-04-20 603 }
4406d36dfdf1fbd Michael Walle 2020-04-20 604 #endif
4406d36dfdf1fbd Michael Walle 2020-04-20 605
6937602ed3f9ebd Michael Walle 2020-04-20 606 phydev_dbg(phydev, "probed (port %d, base PHY address %d)\n",
6937602ed3f9ebd Michael Walle 2020-04-20 607 priv->port, priv->base_addr);
6937602ed3f9ebd Michael Walle 2020-04-20 608
6937602ed3f9ebd Michael Walle 2020-04-20 609 return 0;
6937602ed3f9ebd Michael Walle 2020-04-20 610 }
6937602ed3f9ebd Michael Walle 2020-04-20 611
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki