Re: [PATCH v8 05/11] dt-bindings: allwinner: add H616 DE33 bus binding
From: Rob Herring <robh@kernel.org>
Date: 2025-03-10 12:40:16
Also in:
dri-devel, linux-clk, linux-devicetree, linux-sunxi
On Mon, Mar 10, 2025 at 10:09:51PM +1300, Ryan Walklin wrote:
quoted hunk ↗ jump to hunk
The Allwinner H616 and variants have a new display engine revision (DE33). Add a display engine bus binding for the DE33 and increase reg maxItems to 3 to accommodate additional register blocks. Signed-off-by: Ryan Walklin <redacted> Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Chen-Yu Tsai <redacted> --- Changelog v1..v2: - Correct DE2 bus enum to reflect fallback devices accurately. Changelog v2..v3: - Separate content into three patches for three separate subsystems Changelog v5..v6: - Increase reg maxItems to 3. --- .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml index 9845a187bdf6..317a27cf590b 100644 --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml@@ -24,11 +24,14 @@ properties: oneOf: - const: allwinner,sun50i-a64-de2 - items: - - const: allwinner,sun50i-h6-de3 + - enum: + - allwinner,sun50i-h6-de3 + - allwinner,sun50i-h616-de33 - const: allwinner,sun50i-a64-de2 reg: - maxItems: 1 + minItems: 1 + maxItems: 3
You have to define what each region is and the order. And there should be constraints such that the existing cases don't now allow 2-3 entries.
allwinner,sram:
description:
--
2.48.1