Re: [PATCH v4 1/3] dt-bindings: power: reset: google,gs101-reboot: add Google GS101 specific reset
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-03-31 07:11:32
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
On Fri, Mar 28, 2025 at 03:15:19PM +0000, André Draszik wrote:
quoted hunk ↗ jump to hunk
GS101 supports a couple different reset types via certain registers in the SYSCON register map. Add a binding for this. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- .../bindings/power/reset/google,gs101-reboot.yaml | 32 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 33 insertions(+)diff --git a/Documentation/devicetree/bindings/power/reset/google,gs101-reboot.yaml b/Documentation/devicetree/bindings/power/reset/google,gs101-reboot.yaml new file mode 100644 index 0000000000000000000000000000000000000000..cbd0a1d9b45af0cb994d616c56b96440c43ab971 --- /dev/null +++ b/Documentation/devicetree/bindings/power/reset/google,gs101-reboot.yaml@@ -0,0 +1,32 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/reset/google,gs101-reboot.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Google GS101 syscon-mapped reset + +maintainers: + - André Draszik <andre.draszik@linaro.org> + +description: + GS101 supports a couple different reset types via certain registers in the + SYSCON register map. This map is retrieved from the parental dt-node. So the + gs101-reboot node should be represented as a sub-node of such a node. + +properties: + compatible: + oneOf: + - items:
Just const instead of these two
+ - const: google,gs101-reboot + + priority: + default: 192 + +required: + - compatible + +additionalProperties: false + +allOf: + - $ref: restart-handler.yaml#
Missing example... unless you are adding it in the other patch to the parent node. but then separate schema for just two properties and allOf: is really too much. Altough let me comment on the other patch. Best regards, Krzysztof