Re: [PATCH 1/4] mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe()
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-03-30 10:01:44
Also in:
kernel-janitors, linux-samsung-soc, lkml
On 29/03/2025 08:45, Christophe JAILLET wrote:
If an error occurs after a successful regmap_init_mmio(), regmap_exit()
should be called as already done in the .remove() function.
Switch to devm_regmap_init_mmio() to avoid the leak and simplify the
.remove() function.
Fixes: c695abab2429 ("mfd: Add Samsung Exynos Low Power Audio Subsystem driver")c414df12bdf7 should be fixed instead, I think.
Signed-off-by: Christophe JAILLET <redacted>
---
The .remove function was added in commit c414df12bdf7 ("mfd: exynos-lpass:
Add missing remove() function")Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof