Re: [PATCH 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5

Hi Conor,
    Thanks for your advice.

On 2025/3/28 00:37, Conor Dooley wrote:

ForwardedMessage.eml

Subject:
Re: [PATCH 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible 
string for A5
From:
Conor Dooley [off-list ref]
Date:
2025/3/28 00:37

To:
xianwei.zhao@amlogic.com
CC:
Linus Walleij [off-list ref], Rob Herring [off-list ref], 
Krzysztof Kozlowski [off-list ref], Conor Dooley 
[off-list ref], Neil Armstrong [off-list ref], Kevin 
Hilman [off-list ref], Jerome Brunet [off-list ref], 
Martin Blumenstingl [off-list ref], 
linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, 
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
linux-arm-kernel@lists.infradead.org


On Thu, Mar 27, 2025 at 05:26:35PM +0800, Xianwei Zhao via B4 Relay wrote:

quoted

From: Xianwei Zhao<xianwei.zhao@amlogic.com>

Amlogic A5 SoCs uses the same pintrl controller as A4 SoCs. There is
no need for an extra compatible line in the driver, but add A5
compatible line for documentation.

Signed-off-by: Xianwei Zhao<xianwei.zhao@amlogic.com>
---
  .../devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml          | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml
index 8eb50cad61d5..a94f4dfb9a7f 100644
--- a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml

@@ -14,8 +14,13 @@ allOf:
  
  properties:
    compatible:
-    const: amlogic,pinctrl-a4
-
+    oneOf:
+      - enum:
+          - amlogic,pinctrl-a4

This one here only has a single entry, so could just be
- const: amlogic,pinctrl-a4.

Will do.

With that,
Acked-by: Conor Dooley<conor.dooley@microchip.com>

quoted

+      - items:
+          - enum:
+              - amlogic,pinctrl-a5
+          - const: amlogic,pinctrl-a4
    "#address-cells":
      const: 2
  

-- 
2.37.1