Re: [PATCH 15/34] mfd: sec: use dev_err_probe() where appropriate

[PATCH 00/34] Samsung S2MPG10 PMIC MFD-based drivers · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 01/34] dt-bindings: mfd: samsung,s2mps11: add s2mpg10 · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 01/34] dt-bindings: mfd: samsung,s2mps11: add s2mpg10 · Rob Herring <robh@kernel.org> · 2025-03-24
Re: [PATCH 01/34] dt-bindings: mfd: samsung,s2mps11: add s2mpg10 · André Draszik <andre.draszik@linaro.org> · 2025-03-24
[PATCH 02/34] dt-bindings: clock: samsung,s2mps11: add s2mpg10 · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 02/34] dt-bindings: clock: samsung,s2mps11: add s2mpg10 · "Rob Herring (Arm)" <robh@kernel.org> · 2025-03-24
Re: [PATCH 02/34] dt-bindings: clock: samsung,s2mps11: add s2mpg10 · Stephen Boyd <sboyd@kernel.org> · 2025-03-25
[PATCH 04/34] mfd: sec: drop non-existing forward declarations · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 04/34] mfd: sec: drop non-existing forward declarations · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 03/34] firmware: exynos-acpm: export devm_acpm_get_by_phandle() · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 03/34] firmware: exynos-acpm: export devm_acpm_get_by_phandle() · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
Re: [PATCH 03/34] firmware: exynos-acpm: export devm_acpm_get_by_phandle() · André Draszik <andre.draszik@linaro.org> · 2025-03-26
[PATCH 05/34] mfd: sec: sort includes alphabetically · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 08/34] mfd: sec: fix open parenthesis alignment (of_property_read_bool) · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 08/34] mfd: sec: fix open parenthesis alignment (of_property_read_bool) · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
Re: [PATCH 08/34] mfd: sec: fix open parenthesis alignment (of_property_read_bool) · André Draszik <andre.draszik@linaro.org> · 2025-03-26
Re: [PATCH 08/34] mfd: sec: fix open parenthesis alignment (of_property_read_bool) · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-27
[PATCH 06/34] mfd: sec: update includes to add missing and remove superfluous ones · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 07/34] mfd: sec: move private internal API to internal header · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 07/34] mfd: sec: move private internal API to internal header · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 09/34] mfd: sec: slightly rework runtime platform data allocation · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 09/34] mfd: sec: slightly rework runtime platform data allocation · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 11/34] defconfigs: rename CONFIG_MFD_SEC_CORE to CONFIG_MFD_SEC_I2C · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 11/34] defconfigs: rename CONFIG_MFD_SEC_CORE to CONFIG_MFD_SEC_I2C · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
Re: [PATCH 11/34] defconfigs: rename CONFIG_MFD_SEC_CORE to CONFIG_MFD_SEC_I2C · André Draszik <andre.draszik@linaro.org> · 2025-03-27
Re: [PATCH 11/34] defconfigs: rename CONFIG_MFD_SEC_CORE to CONFIG_MFD_SEC_I2C · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-27
Re: [PATCH 11/34] defconfigs: rename CONFIG_MFD_SEC_CORE to CONFIG_MFD_SEC_I2C · André Draszik <andre.draszik@linaro.org> · 2025-03-27
[PATCH 10/34] mfd: sec: split into core and transport (i2c) drivers · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 10/34] mfd: sec: split into core and transport (i2c) drivers · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
Re: [PATCH 10/34] mfd: sec: split into core and transport (i2c) drivers · André Draszik <andre.draszik@linaro.org> · 2025-03-26
[PATCH 12/34] mfd: sec: add support for S2MPG10 PMIC · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 12/34] mfd: sec: add support for S2MPG10 PMIC · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
Re: [PATCH 12/34] mfd: sec: add support for S2MPG10 PMIC · André Draszik <andre.draszik@linaro.org> · 2025-03-26
[PATCH 13/34] mfd: sec: merge separate core and irq modules · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 13/34] mfd: sec: merge separate core and irq modules · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 15/34] mfd: sec: use dev_err_probe() where appropriate · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 15/34] mfd: sec: use dev_err_probe() where appropriate · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
Re: [PATCH 15/34] mfd: sec: use dev_err_probe() where appropriate · André Draszik <andre.draszik@linaro.org> · 2025-03-26
[PATCH 14/34] mfd: sec: sort struct of_device_id entries and the device type switch · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 14/34] mfd: sec: sort struct of_device_id entries and the device type switch · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 17/34] mfd: sec: drop generic regmap config · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 17/34] mfd: sec: drop generic regmap config · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 16/34] mfd: sec: s2dos05/s2mpu05: use explicit regmap config · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 18/34] mfd: sec: s2dos05: doesn't support interrupts (it seems) · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 18/34] mfd: sec: s2dos05: doesn't support interrupts (it seems) · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 19/34] mfd: sec: don't ignore errors from sec_irq_init() · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 19/34] mfd: sec: don't ignore errors from sec_irq_init() · Krzysztof Kozlowski <krzk@kernel.org> · 2025-03-26
[PATCH 20/34] mfd: sec: rework platform data and regmap instantiating · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 20/34] mfd: sec: rework platform data and regmap instantiating · kernel test robot <hidden> · 2025-03-24
[PATCH 21/34] mfd: sec: change device_type to int · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 23/34] mfd: sec: use sizeof(*var), not sizeof(struct type_of_var) · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 22/34] mfd: sec: don't compare against NULL / 0 for errors, use ! · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 24/34] mfd: sec: convert to using MFD_CELL macros · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 25/34] mfd: sec: convert to using REGMAP_IRQ_REG() macros · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 27/34] rtc: s5m: cache value of platform_get_device_id() during probe · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 26/34] clk: s2mps11: add support for S2MPG10 PMIC clock · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 26/34] clk: s2mps11: add support for S2MPG10 PMIC clock · Stephen Boyd <sboyd@kernel.org> · 2025-03-25
[PATCH 28/34] rtc: s5m: prepare for external regmap · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 29/34] rtc: s5m: add support for S2MPG10 RTC · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 30/34] rtc: s5m: fix a typo: peding -> pending · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 31/34] rtc: s5m: switch to devm_device_init_wakeup · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 32/34] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 33/34] rtc: s5m: replace open-coded read/modify/write registers with regmap helpers · André Draszik <andre.draszik@linaro.org> · 2025-03-23
[PATCH 34/34] MAINTAINERS: add myself as reviewer for Samsung S2M MFD · André Draszik <andre.draszik@linaro.org> · 2025-03-23
Re: [PATCH 00/34] Samsung S2MPG10 PMIC MFD-based drivers · Lee Jones <lee@kernel.org> · 2025-03-28

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-03-26 07:24:42
Also in: linux-clk, linux-devicetree, linux-rtc, linux-samsung-soc, lkml

On 23/03/2025 23:39, André Draszik wrote:

dev_err_probe() exists to simplify code and harmonise error messages,
there's no reason not to use it here.

While at it, harmonise some error messages.

Signed-off-by: André Draszik <andre.draszik@linaro.org>

Maybe such cleanups should be before you start moving the code and
splitting modules into i2c/core/acpm.

Anyway:

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help