Thread (5 messages) 5 messages, 4 authors, 2025-03-21

Re: [PATCH] arm64: dts: amlogic: a4: fix dtb compilation warning issues

From: Xianwei Zhao <xianwei.zhao@amlogic.com>
Date: 2025-03-21 09:58:09
Also in: linux-amlogic, linux-devicetree, lkml

Hi Krzysztof,
     Thanks for your reply.

On 2025/3/21 17:25, Krzysztof Kozlowski wrote:
[ EXTERNAL EMAIL ]

On 21/03/2025 03:23, Xianwei Zhao via B4 Relay wrote:
quoted
From: Xianwei Zhao <xianwei.zhao@amlogic.com>

When use command 'make ARCH=arm64 dtbs_check W=1' to compile dtb,
a warning message appears.
"Warning (simple_bus_reg): /soc/bus@fe000000/pinctrl:
missing or empty reg/ranges property"

Add the unit address to the pinctrl node to fix it.

Fixes: ce78f679e08c ("arm64: dts: amlogic: a4: add pinctrl node")
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
  arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102 +++++++++++++++-------------
  1 file changed, 55 insertions(+), 47 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
index fa80fa365f13..582e0043024b 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
@@ -51,87 +51,52 @@ pwrc: power-controller {
  };

  &apb {
-     gpio_intc: interrupt-controller@4080 {
-             compatible = "amlogic,a4-gpio-intc",
-                          "amlogic,meson-gpio-intc";
-             reg = <0x0 0x4080 0x0 0x20>;
-             interrupt-controller;
-             #interrupt-cells = <2>;
-             amlogic,channel-interrupts =
-                     <10 11 12 13 14 15 16 17 18 19 20 21>;
-     };
-
-     gpio_ao_intc: interrupt-controller@8e72c {
-             compatible = "amlogic,a4-gpio-ao-intc",
-                          "amlogic,meson-gpio-intc";
-             reg = <0x0 0x8e72c 0x0 0x0c>;
-             interrupt-controller;
-             #interrupt-cells = <2>;
-             amlogic,channel-interrupts = <140 141>;
-     };

Not related to the change you described in commit msg.
I will add the corresponding description in commit msg.
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help