Re: [PATCH v2 3/3] nvmem: rockchip-otp: Add support for rk3562
From: Jonas Karlman <jonas@kwiboo.se>
Date: 2025-03-16 21:26:07
Also in:
linux-rockchip, lkml
Hi Kever, On 2025-02-27 12:08, Kever Yang wrote:
quoted hunk ↗ jump to hunk
From: Finley Xiao <redacted> This adds the necessary data for handling otp on the rk3562. Signed-off-by: Finley Xiao <redacted> Signed-off-by: Kever Yang <redacted> --- Changes in v2: None drivers/nvmem/rockchip-otp.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c index a04bce89ecc8..6f86cf8ec390 100644 --- a/drivers/nvmem/rockchip-otp.c +++ b/drivers/nvmem/rockchip-otp.c@@ -341,6 +341,17 @@ static const struct rockchip_data px30_data = { .reg_read = px30_otp_read, }; +static const char * const rk3562_otp_clocks[] = { + "usr", "sbpi", "apb_pclk", "phy", +};
These are the same clocks as used for rk3568 below.
quoted hunk ↗ jump to hunk
+ +static const struct rockchip_data rk3562_data = { + .size = 0x80, + .clks = rk3562_otp_clocks, + .num_clks = ARRAY_SIZE(rk3562_otp_clocks), + .reg_read = rk3568_otp_read, +}; + static const char * const rk3568_otp_clocks[] = { "usr", "sbpi", "apb_pclk", "phy", };@@ -372,6 +383,10 @@ static const struct of_device_id rockchip_otp_match[] = { .compatible = "rockchip,rk3308-otp", .data = &px30_data, }, + { + .compatible = "rockchip,rk3562-otp", + .data = &rk3562_data,
Here we can use rk3568_data directly without having to add a new rk3562_data struct. Regards, Jonas
+ },
{
.compatible = "rockchip,rk3568-otp",
.data = &rk3568_data,