Thread (3 messages) 3 messages, 3 authors, 2025-03-17

Re: [PATCH v2] mmc: sdhci-brcmstb: add cqhci suspend/resume to PM ops

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2025-03-13 15:13:41
Also in: linux-mmc, lkml, stable


On 3/11/2025 9:59 AM, Kamal Dasu wrote:
quoted hunk ↗ jump to hunk
cqhci timeouts observed on brcmstb platforms during suspend:
   ...
   [  164.832853] mmc0: cqhci: timeout for tag 18
   ...

Adding cqhci_suspend()/resume() calls to disable cqe
in sdhci_brcmstb_suspend()/resume() respectively to fix
CQE timeouts seen on PM suspend.

Fixes: d46ba2d17f90 ("mmc: sdhci-brcmstb: Add support for Command Queuing (CQE)")
Cc: stable@vger.kernel.org
Signed-off-by: Kamal Dasu <kamal.dasu@broadcom.com>
---
  drivers/mmc/host/sdhci-brcmstb.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index 0ef4d578ade8..48cdcba0f39c 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -503,8 +503,15 @@ static int sdhci_brcmstb_suspend(struct device *dev)
  	struct sdhci_host *host = dev_get_drvdata(dev);
  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
  	struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host);
+	int ret;
Hopefully this won't be causing a possibly uninitialized warning.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help