Thread (10 messages) 10 messages, 2 authors, 2025-03-13

Re: [PATCH v4 4/4] drivers/thermal/exymos: Use guard notation when acquiring mutex

From: Anand Moon <hidden>
Date: 2025-03-13 10:35:37
Also in: linux-pm, linux-samsung-soc, lkml

Hi Krzysztof,

On Thu, 13 Mar 2025 at 13:19, Krzysztof Kozlowski [off-list ref] wrote:
On 12/03/2025 15:59, Anand Moon wrote:
quoted
quoted
quoted
+          mutex_lock(&_T->lock), mutex_unlock(&_T->lock))
+
 /*
  * TMU treats temperature as a mapped temperature code.
  * The temperature is converted differently depending on the calibration type.
@@ -256,7 +260,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
      unsigned int status;
      int ret = 0;

-     mutex_lock(&data->lock);
+     guard(mutex)(&data->lock);
Which you do not use... Please don't use cleanup.h if you do not know
it. It leads to bugs.
Ok, I will drop this include of cleanup.h.
So the guards as well...
Ok I will drop this patch thanks.
Best regards,
Krzysztof
Thanks
-Anand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help