Re: [PATCH 3/7] ASoC: dt-bindings: add schema for rockchip SAI controllers
From: Rob Herring <robh@kernel.org>
Date: 2025-03-07 20:56:40
Also in:
linux-clk, linux-devicetree, linux-rockchip, linux-sound, lkml
On Wed, Mar 05, 2025 at 10:24:23PM +0100, Nicolas Frattaroli wrote:
quoted hunk ↗ jump to hunk
Rockchip introduced a new audio controller called the "Serial Audio Interface", or "SAI" for short, on some of their newer SoCs. In particular, this controller is used several times on the RK3576 SoC. Add a schema for it, with only an RK3576 compatible for now. Other SoCs may follow as mainline support for them lands. Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> --- .../devicetree/bindings/sound/rockchip,sai.yaml | 151 +++++++++++++++++++++ MAINTAINERS | 6 + 2 files changed, 157 insertions(+)diff --git a/Documentation/devicetree/bindings/sound/rockchip,sai.yaml b/Documentation/devicetree/bindings/sound/rockchip,sai.yaml new file mode 100644 index 0000000000000000000000000000000000000000..8f5a292a7f2a6c737d983d00cbe40ec45bfa6249 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rockchip,sai.yaml@@ -0,0 +1,151 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/rockchip,sai.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip Serial Audio Interface Controller + +description: + The Rockchip Serial Audio Interface (SAI) controller is a flexible audio + controller that implements the I2S, I2S/TDM and the PDM standards. + +maintainers: + - Nicolas Frattaroli <nicolas.frattaroli@collabora.com> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: rockchip,rk3576-sai + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + dmas: + minItems: 1 + maxItems: 2 + + dma-names: + minItems: 1 + maxItems: 2 + oneOf: + - const: tx + - const: rx + - items: + - const: tx + - const: rx
You can simplify this to: minItems: 1 items: - enum: [tx, rx] - const: rx (By default, we require unique items, so '"rx", "rx"' won't be allowed. Rob