Thread (11 messages) 11 messages, 5 authors, 2025-03-07

Re: [PATCH v3 2/4] irqchip: Add support for Amlogic A4 and A5 SoCs

From: Thomas Gleixner <hidden>
Date: 2025-03-07 08:01:43
Also in: linux-amlogic, linux-devicetree, lkml

On Wed, Mar 05 2025 at 18:02, Xianwei Zhao via wrote:
quoted hunk ↗ jump to hunk
@@ -358,16 +385,19 @@ static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ctl,
 {
 	u32 val = 0;
 	unsigned int idx;
+	const struct meson_gpio_irq_params *params;
+
+	params = ctl->params;
Please fix up the variable declaration according to

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations

and initialize params right in the declaration. 

Thanks,

        tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help