Re: [PATCH v5 8/9] coresight-tmc: change tmc_drvdata spinlock's type to raw_spinlock_t
From: Yeoreum Yun <hidden>
Date: 2025-03-06 10:35:29
Also in:
linux-rt-devel, lkml
Hi, Suzuki
Unfortunately, this still doesn't cover the current coresight next branch. I
get build errors as below :
"[PATCH] coresight-tmc: change tmc_drvdata spinlock's type to" has style
problems, please review. This is because, we merged the coresight panic
trace support in the coresight next, on 21st Feb.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
CALL scripts/checksyscalls.sh
CC [M] drivers/hwtracing/coresight/coresight-tmc-core.o
CC [M] drivers/hwtracing/coresight/coresight-tmc-etf.o
CC [M] drivers/hwtracing/coresight/coresight-tmc-etr.o
CC [M] drivers/hwtracing/coresight/coresight-catu.o
In file included from ./include/linux/mmzone.h:8,
from ./include/linux/gfp.h:7,
from ./include/linux/slab.h:16,
from ./include/linux/resource_ext.h:11,
from ./include/linux/acpi.h:13,
from drivers/hwtracing/coresight/coresight-tmc-core.c:7:
drivers/hwtracing/coresight/coresight-tmc-core.c: In function
‘tmc_crashdata_open’:
drivers/hwtracing/coresight/coresight-tmc-core.c:361:20: error: passing
argument 1 of ‘spinlock_check’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
361 | spin_lock_irqsave(&drvdata->spinlock, flags);
| ^~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
./include/linux/spinlock.h:244:34: note: in definition of macro
‘raw_spin_lock_irqsave’
244 | flags = _raw_spin_lock_irqsave(lock); \
| ^~~~
drivers/hwtracing/coresight/coresight-tmc-core.c:361:2: note: in expansion
of macro ‘spin_lock_irqsave’
361 | spin_lock_irqsave(&drvdata->spinlock, flags);
| ^~~~~~~~~~~~~~~~~
In file included from ./include/linux/mmzone.h:8,
from ./include/linux/gfp.h:7,
from ./include/linux/slab.h:16,
from ./include/linux/resource_ext.h:11,
from ./include/linux/acpi.h:13,
from drivers/hwtracing/coresight/coresight-tmc-core.c:7:
./include/linux/spinlock.h:324:67: note: expected ‘spinlock_t *’ {aka
‘struct spinlock *’} but argument is of type ‘raw_spinlock_t *’ {aka ‘struct
raw_spinlock *’}
324 | static __always_inline raw_spinlock_t *spinlock_check(spinlock_t
*lock)Sorry! I'll rework again for this. thanks!