Re: [PATCH v3 3/6] pmdomain: imx93-blk-ctrl: Scan subnodes and bind drivers to them
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-03-05 07:17:27
Also in:
imx, linux-clk, linux-devicetree, linux-pm, lkml
On Tue, Mar 04, 2025 at 04:49:22PM +0100, Alexander Stein wrote:
quoted hunk ↗ jump to hunk
+#include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/pm_runtime.h>@@ -297,8 +298,14 @@ static int imx93_blk_ctrl_probe(struct platform_device *pdev) dev_set_drvdata(dev, bc); + ret = devm_of_platform_populate(dev);
This means in remove() you will depopulate in different order than error path (e.g. after genpd removal). This is rather unexpected - remove() should be cleaning up in exactly reversed order of probe. Not sure if it can lead to any issues, but usual recommendation is that you either use devm() or not. Best regards, Krzysztof