Re: [RFC/RFT PATCH] pinctrl: bcm2835: don't -EINVAL on alternate funcs from get_direction()
From: Linus Walleij <hidden>
Date: 2025-03-04 07:53:16
Also in:
linux-gpio, lkml
On Wed, Feb 19, 2025 at 11:27 AM Bartosz Golaszewski [off-list ref] wrote:
From: Bartosz Golaszewski <redacted>
Since commit 9d846b1aebbe ("gpiolib: check the return value of
gpio_chip::get_direction()") we check the return value of the
get_direction() callback as per its API contract. This driver returns
-EINVAL if the pin in question is set to one of the alternative
(non-GPIO) functions. This isn't really an error that should be
communicated to GPIOLIB so default to returning the "safe" value of
INPUT in this case. The GPIO subsystem does not have the notion of
"unknown" direction.
Fixes: 9d846b1aebbe ("gpiolib: check the return value of gpio_chip::get_direction()")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/Z7VFB1nST6lbmBIo@finisterre.sirena.org.uk/ (local)
Signed-off-by: Bartosz Golaszewski <redacted>Patch applied! Yours, Linus Walleij