Thread (34 messages) 34 messages, 8 authors, 2025-03-11

Re: [PATCH v2 3/4] arm64/mm: Elide tlbi in contpte_convert() under BBML2

From: David Hildenbrand <hidden>
Date: 2025-03-03 09:17:27
Also in: linux-iommu, lkml

On 28.02.25 19:24, Mikołaj Lenczewski wrote:
quoted hunk ↗ jump to hunk
If we support bbml2 without conflict aborts, we can avoid the final
flush and have hardware manage the tlb entries for us. Avoiding flushes
is a win.

Signed-off-by: Mikołaj Lenczewski <redacted>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
---
  arch/arm64/mm/contpte.c | 3 ---
  1 file changed, 3 deletions(-)
diff --git a/arch/arm64/mm/contpte.c b/arch/arm64/mm/contpte.c
index 145530f706a9..77ed03b30b72 100644
--- a/arch/arm64/mm/contpte.c
+++ b/arch/arm64/mm/contpte.c
@@ -72,9 +72,6 @@ static void contpte_convert(struct mm_struct *mm, unsigned long addr,
  		__flush_tlb_range(&vma, start_addr, addr, PAGE_SIZE, true, 3);
  
  	__set_ptes(mm, start_addr, start_ptep, pte, CONT_PTES);
-
-	if (system_supports_bbml2_noabort())
-		__flush_tlb_range(&vma, start_addr, addr, PAGE_SIZE, true, 3);
  }
  
  void __contpte_try_fold(struct mm_struct *mm, unsigned long addr,
What's the point of not squashing this into #2? :)

If this split was requested during earlier review, at least seeing patch 
#2 on its own confused me.

-- 
Cheers,

David / dhildenb

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help