Thread (7 messages) flat view 7 messages, 2 authors, 2025-03-01

Re: [PATCH net 2/2] net: ethtool: netlink: Pass a context for default ethnl notifications

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2025-03-01 09:53:56
Also in: lkml, netdev

On Fri, 28 Feb 2025 18:24:40 -0800
Jakub Kicinski [off-list ref] wrote:
On Thu, 27 Feb 2025 19:24:52 +0100 Maxime Chevallier wrote:
quoted
The only relevant user for now is PLCA, and it very likely that we never
ended-up in a situation where the follow-up notif wasn't targeting the
correct PHY as :  
PLCA uses the ethnl_default_* handlers but it seems to operate on PHYs
now. How does the dump work? Shoehorning the PHY support into
the ethnl_default_* handlers is starting to look pretty messy.
I agree, that's the less ugly quick solution I could think of :(

So maybe we need some generic PHY dump support for all PHY commands ?

I should probably re-send patch 1 only to fix the crash, and rework the
dump/notify for PHY commands separately if this is OK for you ?

Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help