-----Original Message-----
From: Marc Zyngier <maz@kernel.org>
Sent: Friday, February 14, 2025 4:43 PM
To: Sebastian Ott <redacted>
Cc: Shameerali Kolothum Thodi
[off-list ref]; kvmarm@lists.linux.dev;
oliver.upton@linux.dev; catalin.marinas@arm.com; will@kernel.org;
mark.rutland@arm.com; cohuck@redhat.com; eric.auger@redhat.com;
yuzenghui [off-list ref]; Wangzhou (B)
[off-list ref]; jiangkunkun [off-list ref];
Jonathan Cameron [off-list ref]; Anthony Jebson
[off-list ref]; linux-arm-kernel@lists.infradead.org;
Linuxarm [off-list ref]
Subject: Re: [PATCH v7 4/5] smccc/kvm_guest: Enable errata based on
implementation CPUs

On Fri, 14 Feb 2025 16:12:02 +0000,
Sebastian Ott [off-list ref] wrote:

quoted

On Fri, 14 Feb 2025, Shameer Kolothum wrote:

quoted

+++ b/arch/arm64/kernel/cpu_errata.c

@@ -14,6 +14,9 @@

#include <asm/kvm_asm.h>
#include <asm/smp_plat.h>

+u32 target_impl_cpu_num;
+struct target_impl_cpu *target_impl_cpus;

These should be exported (for configs using
CONFIG_CORESIGHT_SOURCE_ETM4X=m)

Thanks Sebastian. I missed that.

It might be better to make is_midr_in_range() out of line, and export
that. This could allow making the data static (by implementing a
couple of additional accessors).

Ok. I will give it a go.

Thanks,
Shameer