Re: [PATCH 5/8] arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSI

On Sat, 22 Feb 2025, at 10:45 PM, Jernej Škrabec wrote:

Dne nedelja, 16. februar 2025 ob 10:27:12 Srednjeevropski standardni 

quoted

Add TCON nodes for the TOP, and the LCD and TV timing controllers. The
timing controllers are compatible with the existing R40 driver.
+			resets = <&ccu RST_BUS_TCON_LCD0>, <&ccu RST_BUS_TCON_LCD1>;
+			reset-names = "lcd", "lvds";

That's not true, is it? LVDS should be LVDS reset. Check my WIP patch:
https://github.com/jernejsk/linux-1/commit/8b090dc866d4c4b5b0a1804da021a9f44c67d5f1

Thanks, will correct for next version.

It turns out that H616 clock driver missed LVDS reset, as it can be 
seen here:
https://github.com/jernejsk/linux-1/commit/88bad1a59876f5d385bcd45a363784ed2beec6ae#diff-b340c978bcdbe240f7b99f4d0d96ea130a8acb1a5786a8efbb24d9e7a0b14e53R1084

I also commented on this series:
https://lore.kernel.org/linux-sunxi/20250213172248.158447-1-macroalpha82@gmail.com/T/#t (local)

Thanks, I will add those in for next version with this patch.

Regards,

Ryan