Re: [PATCH net-next v3 09/13] net: phylink: Use phy_caps_lookup for fixed-link configuration

On Fri, 28 Feb 2025 16:20:54 +0000
"Russell King (Oracle)" [off-list ref] wrote:

On Fri, Feb 28, 2025 at 03:55:34PM +0100, Maxime Chevallier wrote:

quoted

 	adv = pl->link_config.advertising;
 	linkmode_zero(adv);
-	linkmode_set_bit(s->bit, adv);
+	linkmode_and(adv, pl->supported, c->linkmodes);  

There is no need for linkmode_zero() with linkmode_and() immediately
after. linkmode_and() writes to its entire destination.

Ah true indeed, I'll address that.

Thanks Russell,

Maxime