Thread (6 messages) 6 messages, 2 authors, 2025-03-03

Re: [PATCH v1 1/2] phy: freescale: imx8m-pcie: cleanup reset logic

From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2025-02-28 12:38:26
Also in: imx, linux-phy, lkml

On Fr, 2025-02-28 at 11:38 +0100, Stefan Eichenberger wrote:
quoted hunk ↗ jump to hunk
From: Stefan Eichenberger <redacted>

Remove the switch statement and base perst release on whether it is
found in the device tree. The probe function fails without the reset
property, making it mandatory. Therefore, always release reset
independent of the variant.

This does not change the behavior of the driver but reduces driver
complexity and allows for easier future modifications.

Signed-off-by: Stefan Eichenberger <redacted>
---
 drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index e98361dcdeadf..00f957a42d9dc 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -141,15 +141,11 @@ static int imx8_pcie_phy_power_on(struct phy *phy)
 			   IMX8MM_GPR_PCIE_REF_CLK_PLL);
 	usleep_range(100, 200);
 
-	switch (imx8_phy->drvdata->variant) {
-	case IMX8MP:
+	if (imx8_phy->perst)
This check is not necessary, reset_control_deassert(NULL) is a no-op:
 		reset_control_deassert(imx8_phy->perst);
regards
Philipp
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help