Re: [PATCH v2 1/4] dt-bindings: reset: Add Armada8K reset controller

On 22/02/2025 21:57, Wilson Ding wrote:

quoted

quoted

quoted

+  offset:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Offset in the register map for the gpio registers
+ (in bytes)

That's neither correct nor needed. Your device knows ofsset based on
the compatible.

Or use 'reg'.

But really, just add #reset-cells to the parent node. There's no need for a child
node here. The parent needs a specific compatible though.

I am not inventing the 'offset' property. I just tried to follow the other existing
sub-nodes under the same parent node (system-controller). The mvebu-gpio
driver also uses 'offset' instead of 'reg' for the syscon device (see below). But it

You never answered why do you need offset and why it cannot work without.

seems also not correct from your point of view. Now, I am a bit confused what
should be the right scheme for the Armada's system-controller, including GPIO
and Reset controller. And dt_binding_check complains "system-controller@
440000:  compatible: ['syscon', 'simple-mfd'] is too short". Can you point me
any  reference for me to fix these issues.

See all other syscon devices. 'git grep simple-mfd' or for syscon

CP110_LABEL(syscon0): system-controller@440000 {
	compatible = "syscon", "simple-mfd";
	reg = <0x440000 0x1000>;

Best regards,
Krzysztof