Re: [PATCH v5 01/10] arm64: dts: ti: k3-am62-wakeup: Add wakeup R5F node
From: Judith Mendez <hidden>
Date: 2025-02-20 16:35:15
Also in:
linux-devicetree, lkml
Hi Beleswar, On 2/19/25 10:30 AM, Beleswar Prasad Padhi wrote:
Hi Judith, On 11/02/25 03:45, Judith Mendez wrote:quoted
From: Hari Nagalla <redacted> AM62 SoC devices have a single core R5F processor in wakeup domain. The R5F processor in wakeup domain is used as a device manager for the SoC. Signed-off-by: Devarsh Thakkar <devarsht@ti.com> Signed-off-by: Hari Nagalla <redacted> Signed-off-by: Judith Mendez <redacted> --- Changes since v4: - No change --- arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+)diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsib/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi index 9b8a1f85aa15c..061819a64300f 100644--- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi@@ -106,6 +106,31 @@ wkup_rti0: watchdog@2b000000 {status = "reserved"; }; + wkup_r5fss0: r5fss@78000000 { + compatible = "ti,am62-r5fss"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x78000000 0x00 0x78000000 0x8000>, + <0x78100000 0x00 0x78100000 0x8000>; + power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; + status = "disabled"; + + wkup_r5fss0_core0: r5f@78000000 { + compatible = "ti,am62-r5f"; + reg = <0x78000000 0x00008000>, + <0x78100000 0x00008000>; + reg-names = "atcm", "btcm"; + ti,sci = <&dmsc>; + ti,sci-dev-id = <121>; + ti,sci-proc-ids = <0x01 0xff>; + resets = <&k3_reset 121 1>; + firmware-name = "am62-wkup-r5f0_0-fw";Here and everywhere else, 'resets' and 'firmware-name' are standard DT properties and should come before vendor specific properties.
Right, let me fix that, thanks. ~ Judith
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Thanks, Beleswarquoted
+ ti,atcm-enable = <1>; + ti,btcm-enable = <1>; + ti,loczrama = <1>; + }; + }; + wkup_vtm0: temperature-sensor@b00000 { compatible = "ti,j7200-vtm"; reg = <0x00 0xb00000 0x00 0x400>,