Re: [PATCH iwl-next v4 5/9] igc: Add support for frame preemption verification

From
Abdul Rahim, Faizal <hidden>
Date
2025-02-19 01:48:50
Also in
bpf, intel-wired-lan, lkml, netdev
Reply to
Simon Horman, 2025-02-17

On 17/2/2025 7:31 pm, Simon Horman wrote:
On Mon, Feb 10, 2025 at 02:02:03AM -0500, Faizal Rahim wrote:

...
quoted
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c
...
quoted
+bool igc_fpe_transmitted_smd_v(union igc_adv_tx_desc *tx_desc)
+{
+	u8 smd = FIELD_GET(IGC_TXD_POPTS_SMD_MASK, tx_desc->read.olinfo_status);
olininfo_status is little-endian, so I think it needs
to be converted to host byte order when used as an
argument to FIELD_GET().

Flagged by Sparse.
quoted
+
+	return smd == SMD_V;
+}
...
quoted
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.h b/drivers/net/ethernet/intel/igc/igc_tsn.h
...
quoted
+static inline void igc_fpe_lp_event_status(union igc_adv_rx_desc *rx_desc,
+					   struct ethtool_mmsv *mmsv)
+{
+	__le32 status_error = le32_to_cpu(rx_desc->wb.upper.status_error);
It looks like the type of status_error should be a host byte order integer,
such as u32.

Also flagged by Sparse.
Thanks for spotting these, I'll update them.

Thread (15 messages) 15 messages, 3 authors, last reply 2025-02-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help