Re: [PATCH] soc: apple: rtkit: Fix use-after-free in apple_rtkit_crashlog_rx()
From: Sven Peter <hidden>
Date: 2025-02-18 17:05:34
Also in:
asahi, kernel-janitors, lkml
From: Sven Peter <hidden>
Date: 2025-02-18 17:05:34
Also in:
asahi, kernel-janitors, lkml
On Wed, 12 Feb 2025 00:58:53 -0800, Harshit Mogalapalli wrote:
This code calls kfree(bfr); and then passes "bfr" to rtk->ops->crashed() which is a use after free. The ->crashed function pointer is implemented by apple_nvme_rtkit_crashed() and it doesn't use the "bfr" pointer so this doesn't cause a problem. But it still looks sketchy as can be. Fix this by moving kfree() after the last usage of bfr. [...]
Applied, thanks!
[1/1] soc: apple: rtkit: Fix use-after-free in apple_rtkit_crashlog_rx()
commit: 00834971f0d9e38beae37e92055b1432782827d0
Best regards,
--
Sven Peter [off-list ref]